Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Natural scrolling is backwards for knobs, spinboxes #5507

Closed
tresf opened this issue May 19, 2020 · 5 comments · Fixed by #5510
Closed

Natural scrolling is backwards for knobs, spinboxes #5507

tresf opened this issue May 19, 2020 · 5 comments · Fixed by #5510

Comments

@tresf
Copy link
Member

tresf commented May 19, 2020

Quoting #5360 (comment):

the mouse-wheel emulation is completely bazaar on Mac (disregarding the reverseness), the scrolling emulates a list/document moving at an animated pace. This isn't how it behaves in apps like GarageBand [...] whereas the LMMS MASTER VOLUME SLIDER works properly with this gesture but the knobs and spinboxes do not. This may mean we have a bug somewhere?

@PhysSong
Copy link
Member

Qt 5.7 provides QWheelEvent::inverted() which allows checking for natural scrolling. FYI, LMMS currently requires Qt 5.6.

@tresf
Copy link
Member Author

tresf commented May 21, 2020

Qt 5.7 provides QWheelEvent::inverted() which allows checking for natural scrolling. FYI, LMMS currently requires Qt 5.6.

Why does the master volume work just fine though?

@PhysSong
Copy link
Member

Because QAbstractSlider uses that by default.

@tresf
Copy link
Member Author

tresf commented May 21, 2020

Because QAbstractSlider uses that by default.

So a precompiler check plus the inverted should do it?

@PhysSong
Copy link
Member

Copied from #5510:

File Needs Flip
src/gui/editors/AutomationEditor.cpp ✅(excluding horizontal scroll)
src/gui/editors/PianoRoll.cpp ✅(note panning)
src/gui/editors/SongEditor.cpp ✅(excluding horizontal scroll)
src/gui/widgets/ComboBox.cpp
vsrc/gui/widgets/Fader.cpp
src/gui/widgets/Knob.cpp
src/gui/widgets/LcdSpinBox.cpp
src/gui/widgets/TabWidget.cpp ✖️(no, but could use proper card-swipe support)
src/tracks/Pattern.cpp ✅(Velocity for beat/bassline editor)

@tresf Said:

I'm not sure about where the delta() is used for some of the editors. If it's scrubbing/scroll bars, that's behaving properly, but I notices that note panning on Piano Roll needs it so I might be missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants