Error Report Can Go Offscreen

[Spekular]

If a large number of samples & VSTs fail to load, the error report displayed may grow tall enough to go off the screen.

I believe the prompt should instead stay onscreen (never grow taller than screen size) and display a scrollbar. The ability to resize the prompt horizontally would also allow longer paths to display in fewer lines.

[Sawuare]

The error reports use a QMessageBox, which doesn't support scroll bars. It's supposed to support a size grip, but it doesn't seem to work when I tried it.

It takes a lot of errors for the report to go off-screen. so I don't think it's worth a custom dialog.

[Spekular]

Seems to me a QScrollArea can be applied to any other widget: https://doc.qt.io/qt-5/qscrollarea.html#details

…

On Thu, Apr 26, 2018, 11:01 Hussam Eddin Alhomsi ***@***.***> wrote: The error reports use a QMessageBox <https://doc.qt.io/qt-5/qmessagebox.html>, which doesn't support scroll bars. It's supposed to support a size grip, but it doesn't seem to work when I tried it. It takes *a lot* of errors for the report to go off-screen. so I don't think it's worth a custom dialog. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4312 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AIgVmhCOeN_FfXwRM_N-0HJKk3SZK_JEks5tsYzkgaJpZM4TeysH> .

[Sawuare]

I tried to add a scroll area before and it did not work, but now it does. I will fix this.

[Sawuare]

So applying a scroll area does not work as expected.

• The message box is inside a scroll area window, instead of its own window.
• The window is not centered and is non-modal (does not block input to other windows).
• Window title cannot be changed.
• OK button is not always visible.

I might be doing something wrong though, so for comparison, here is my code:

QMessageBox * mb = new QMessageBox;
mb->setWindowTitle(tr("LMMS Error report"));
mb->setText(errorSummary());
mb->setIcon(QMessageBox::Warning);

QScrollArea * sa = new QScrollArea;
sa->setHorizontalScrollBarPolicy(Qt::ScrollBarAsNeeded);
sa->setVerticalScrollBarPolicy(Qt::ScrollBarAsNeeded);
sa->setWidget(mb);
sa->show();

and the current code:

QMessageBox::warning( NULL, tr("LMMS Error report"), errorSummary(), QMessageBox::Ok );