Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed title revert after render #4160

Closed
enp2s0 opened this issue Feb 7, 2018 · 3 comments
Closed

Failed title revert after render #4160

enp2s0 opened this issue Feb 7, 2018 · 3 comments

Comments

@enp2s0
Copy link
Contributor

enp2s0 commented Feb 7, 2018

After rendering a song, the main window title fails to revert to its normal title and remains as "Rendering: 100%".

Reproduce
open a song
render it
look at main window title, even after the render is complete it stays as "Rendering: 100%"

This is probably a simple fix...

@zonkmachine
Copy link
Member

The function that resets the window title is MainWindow::resetWindowTitle().
I could replicate this with the Qt5 AppImage but not on compiling the Qt4 version.

This is probably a simple fix...

I dare you...

@enp2s0
Copy link
Contributor Author

enp2s0 commented Feb 9, 2018

A one-line change was all that was needed, I've created a pull request with the change. Should I close this issue?

PR: #4161

@tresf
Copy link
Member

tresf commented Feb 9, 2018

@noahb01 thanks for taking the time to document and fix this! This is really a good candidate for stable-1.2. This would throw your master branch out of whack and that's overkill for a one-liner, I'll take it from here.

@tresf tresf closed this as completed in a39ea2b Feb 9, 2018
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants