Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckSubmodules won't fetch rpmalloc #3993

Closed
tresf opened this issue Nov 20, 2017 · 1 comment
Closed

CheckSubmodules won't fetch rpmalloc #3993

tresf opened this issue Nov 20, 2017 · 1 comment

Comments

@tresf
Copy link
Member

tresf commented Nov 20, 2017

rpmalloc uses a non-default branch and shallow clones (e.g. --depth 1) don't appear to like this.

The proposed workaround is to have CMake use a workaround when this specific error is detected.

error: no such remote ref 2e0479192b8dfb15e0084969fdf06208cffbfd09
Fetched in submodule path 'src/3rdparty/rpmalloc/rpmalloc', but it did not contain 2e0479192b8dfb15e0084969fdf06208cffbfd09. Direct fetching of that commit failed.

CMake Error at cmake/modules/CheckSubmodules.cmake:134 (MESSAGE):
  /usr/bin/git exited with status of 1
Call Stack (most recent call first):
  CMakeLists.txt:16 (INCLUDE)


-- Configuring incomplete, errors occurred!
@tresf tresf changed the title CheckSubmodule won't fetch rpmalloc CheckSubmodules won't fetch rpmalloc Nov 20, 2017
tresf added a commit to tresf/lmms that referenced this issue Nov 20, 2017
tresf added a commit that referenced this issue Nov 21, 2017
Various CheckSubmodules fixes
Closes #3992, #3993, #3994
@tresf
Copy link
Member Author

tresf commented Nov 21, 2017

Closed via d634ed3.

@tresf tresf closed this as completed Nov 21, 2017
sdasda7777 pushed a commit to sdasda7777/lmms that referenced this issue Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant