Skip to content

adding notes of how i think object builder should be improved #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 20, 2022
Merged

adding notes of how i think object builder should be improved #1444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7861e63
Update index.js
atherdon Aug 1, 2022
fa3ca0f
Merge branch 'main' of github.com-vadim9999:LLazyEmail/markdown-to-em…
vadim9999 Aug 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/domain/objectBuilder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,13 @@ const ERROR_REGEX_CONSTANT = (value) =>
const ERROR_REPLACER_FUNCTION = (value) =>
`something wrong with replacer function ${value}`;


// TODO to make this method working better [improvement]
Comment on lines +20 to +21

Check failure

Code scanning / ESLint

Delete `⏎`

Delete `⏎`
// 1. to handle a case when literal is false, it's very scary
// 2. we really need to be able to handle a situation when replacer isn't defined before (by different reasons)
// 3. does this function works fine with `components`

Check failure

Code scanning / ESLint

Delete `·`

Delete `·`
// 4. when something wrong - i want to have a better output about params that we passed

function objectBuilder(constant, replacer, literal = false) {
// TODO add typeof for checking replacer as a function
// console.log( typeof element.replacer === 'undefined' );
Expand Down