-
Notifications
You must be signed in to change notification settings - Fork 12
[draft] React callbacks #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[draft] React callbacks #1357
Conversation
video1659186589.mp4сс @vadim9999 |
@atherdon what module to use for typography? |
@atherdon can we merge this PR? |
we need to fix merge conflics, but yeah, i think we can merge it if plain generator working |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 74 potential problems in the proposed changes. Check the Files changed tab for more details.
This pull request introduces 8 alerts and fixes 7 when merging d4a98c3 into daa5405 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 55 potential problems in the proposed changes. Check the Files changed tab for more details.
This pull request introduces 7 alerts and fixes 9 when merging c48ab20 into c40eaf0 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 55 potential problems in the proposed changes. Check the Files changed tab for more details.
This pull request introduces 6 alerts and fixes 10 when merging 0c8d274 into c40eaf0 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 25 potential problems in the proposed changes. Check the Files changed tab for more details.
This pull request introduces 6 alerts and fixes 10 when merging 689cbc7 into c40eaf0 - view on LGTM.com new alerts:
fixed alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found 25 potential problems in the proposed changes. Check the Files changed tab for more details.
This pull request introduces 6 alerts and fixes 10 when merging 4a5078f into c40eaf0 - view on LGTM.com new alerts:
fixed alerts:
|
// TODO should we move away checks? | ||
function checkHtml(content) { | ||
// eslint-disable-next-line prefer-regex-literals | ||
const searchPattern = new RegExp('(<table|<tr>|<td|<tbody>)', 'i'); |
Check failure
Code scanning / ESLint
disallow use of the `RegExp` constructor in favor of regular expression literals
// hmm, it can be a problem | ||
// TODO replace with lodash | ||
// eslint-disable-next-line no-plusplus | ||
for (let i = ind; i < ind + 5000; i++) { |
Check failure
Code scanning / ESLint
disallow the unary operators `++` and `--`
isFolderExists('./tests/_generated'); | ||
|
||
console.info('MODE: ', process.env.PARSE, ''); | ||
console.log('Mode', process.env.PARSE); |
Check warning
Code scanning / ESLint
disallow the use of `console`
// } | ||
// TODO we finally can replaceMarkdown()*** for this one. | ||
|
||
export function replaceMarkdownReact(callback_name) { |
Check warning
Code scanning / ESLint
enforce camelcase naming convention
} | ||
|
||
inspectorCheck(mainObject[name]); | ||
const WR3_getWrapper = (name, mainObjectCCL) => { |
Check warning
Code scanning / ESLint
enforce camelcase naming convention
This pull request introduces 6 alerts and fixes 13 when merging c387337 into c40eaf0 - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 6 alerts and fixes 13 when merging 135dbd6 into c40eaf0 - view on LGTM.com new alerts:
fixed alerts:
|
No description provided.