Skip to content

Conversation

atherdon
Copy link
Collaborator

No description provided.

@atherdon atherdon changed the title React callbacks [draft] React callbacks Jul 22, 2022
@atherdon
Copy link
Collaborator Author

video1659186589.mp4

сс @vadim9999

@vadim9999
Copy link
Collaborator

vadim9999 commented Jul 23, 2022

@atherdon what module to use for typography?

@vadim9999
Copy link
Collaborator

@atherdon can we merge this PR?

@atherdon
Copy link
Collaborator Author

we need to fix merge conflics, but yeah, i think we can merge it if plain generator working

@atherdon
Copy link
Collaborator Author

atherdon commented Jul 23, 2022

Just published an update at
image

now we can pass whole config into our components
image

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 74 potential problems in the proposed changes. Check the Files changed tab for more details.

@lgtm-com
Copy link

lgtm-com bot commented Jul 23, 2022

This pull request introduces 8 alerts and fixes 7 when merging d4a98c3 into daa5405 - view on LGTM.com

new alerts:

  • 5 for Unused variable, import, function or class
  • 1 for Useless conditional
  • 1 for Superfluous trailing arguments
  • 1 for Syntax error

fixed alerts:

  • 5 for Unused variable, import, function or class
  • 1 for Superfluous trailing arguments
  • 1 for Invocation of non-function

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 55 potential problems in the proposed changes. Check the Files changed tab for more details.

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2022

This pull request introduces 7 alerts and fixes 9 when merging c48ab20 into c40eaf0 - view on LGTM.com

new alerts:

  • 5 for Superfluous trailing arguments
  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 5 for Unused variable, import, function or class
  • 3 for Superfluous trailing arguments
  • 1 for Invocation of non-function

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 55 potential problems in the proposed changes. Check the Files changed tab for more details.

@lgtm-com
Copy link

lgtm-com bot commented Jul 27, 2022

This pull request introduces 6 alerts and fixes 10 when merging 0c8d274 into c40eaf0 - view on LGTM.com

new alerts:

  • 4 for Superfluous trailing arguments
  • 1 for Useless conditional
  • 1 for Unused variable, import, function or class

fixed alerts:

  • 5 for Unused variable, import, function or class
  • 4 for Superfluous trailing arguments
  • 1 for Invocation of non-function

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 25 potential problems in the proposed changes. Check the Files changed tab for more details.

@lgtm-com
Copy link

lgtm-com bot commented Jul 28, 2022

This pull request introduces 6 alerts and fixes 10 when merging 689cbc7 into c40eaf0 - view on LGTM.com

new alerts:

  • 5 for Superfluous trailing arguments
  • 1 for Useless conditional

fixed alerts:

  • 5 for Unused variable, import, function or class
  • 4 for Superfluous trailing arguments
  • 1 for Invocation of non-function

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found 25 potential problems in the proposed changes. Check the Files changed tab for more details.

@lgtm-com
Copy link

lgtm-com bot commented Jul 28, 2022

This pull request introduces 6 alerts and fixes 10 when merging 4a5078f into c40eaf0 - view on LGTM.com

new alerts:

  • 5 for Superfluous trailing arguments
  • 1 for Useless conditional

fixed alerts:

  • 5 for Unused variable, import, function or class
  • 4 for Superfluous trailing arguments
  • 1 for Invocation of non-function

// TODO should we move away checks?
function checkHtml(content) {
// eslint-disable-next-line prefer-regex-literals
const searchPattern = new RegExp('(<table|<tr>|<td|<tbody>)', 'i');

Check failure

Code scanning / ESLint

disallow use of the `RegExp` constructor in favor of regular expression literals

Use a regular expression literal instead of the 'RegExp' constructor.
// hmm, it can be a problem
// TODO replace with lodash
// eslint-disable-next-line no-plusplus
for (let i = ind; i < ind + 5000; i++) {

Check failure

Code scanning / ESLint

disallow the unary operators `++` and `--`

Unary operator '++' used.
isFolderExists('./tests/_generated');

console.info('MODE: ', process.env.PARSE, '');
console.log('Mode', process.env.PARSE);

Check warning

Code scanning / ESLint

disallow the use of `console`

Unexpected console statement.
// }
// TODO we finally can replaceMarkdown()*** for this one.

export function replaceMarkdownReact(callback_name) {

Check warning

Code scanning / ESLint

enforce camelcase naming convention

Identifier 'callback_name' is not in camel case.
}

inspectorCheck(mainObject[name]);
const WR3_getWrapper = (name, mainObjectCCL) => {

Check warning

Code scanning / ESLint

enforce camelcase naming convention

Identifier 'WR3_getWrapper' is not in camel case.
@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2022

This pull request introduces 6 alerts and fixes 13 when merging c387337 into c40eaf0 - view on LGTM.com

new alerts:

  • 5 for Superfluous trailing arguments
  • 1 for Useless conditional

fixed alerts:

  • 8 for Unused variable, import, function or class
  • 4 for Superfluous trailing arguments
  • 1 for Invocation of non-function

@lgtm-com
Copy link

lgtm-com bot commented Jul 29, 2022

This pull request introduces 6 alerts and fixes 13 when merging 135dbd6 into c40eaf0 - view on LGTM.com

new alerts:

  • 5 for Superfluous trailing arguments
  • 1 for Useless conditional

fixed alerts:

  • 8 for Unused variable, import, function or class
  • 4 for Superfluous trailing arguments
  • 1 for Invocation of non-function

@vadim9999 vadim9999 self-requested a review July 29, 2022 15:41
@vadim9999 vadim9999 merged commit 54325ce into main Jul 29, 2022
@vadim9999 vadim9999 deleted the react-callbacks branch July 31, 2022 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants