Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Notebooks to Thicket Docs #222

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Conversation

michaelmckinsey1
Copy link
Collaborator

@michaelmckinsey1 michaelmckinsey1 commented Nov 4, 2024

Propagate new notebooks from the Thicket tutorial to the Thicket docs.

@michaelmckinsey1
Copy link
Collaborator Author

michaelmckinsey1 commented Nov 4, 2024

Data type cannot be displayed: application/vnd.plotly.v1+json error at the bottom of tma_speedup_clustering.html for PCP plots. It's because they are interactive.

Fixed in 781c45e

@michaelmckinsey1
Copy link
Collaborator Author

Haven't noticed this until now, but should tma_speedup_clustering.html replace thicket_rajaperf_clustering.html?

@slabasan
Copy link
Collaborator

slabasan commented Nov 4, 2024

@michaelmckinsey1 Do you want to add the NCU one too? Good question on replacing thicket_rajaperf_clustering.html. This is reproducing figures from the HPDC paper, so I'm inclined to keep it. I realize you have improved the analysis in this notebook though.

@michaelmckinsey1
Copy link
Collaborator Author

michaelmckinsey1 commented Nov 4, 2024

@michaelmckinsey1 Do you want to add the NCU one too? Good question on replacing thicket_rajaperf_clustering.html. This is reproducing figures from the HPDC paper, so I'm inclined to keep it. I realize you have improved the analysis in this notebook though.

I will add NCU and the parallel sorting. Maybe we should add HPDC 23 and SC 24 in the titles?

Like Clustering RAJA Performance Suite Dataset (HPDC '23): Thicket Tutorial and RAJA Performance Suite Clustering Analysis (SC '24): Thicket Tutorial

@michaelmckinsey1 michaelmckinsey1 added area-docs Issues and PRs related to Thicket's documentation, notebooks, and examples priority-normal Normal priority issues and PRs type-feature Requests for new features or PRs which implement new features status-ready-for-review This PR is ready to be reviewed by assigned reviewers labels Nov 4, 2024
@michaelmckinsey1 michaelmckinsey1 marked this pull request as ready for review November 4, 2024 23:27
@michaelmckinsey1 michaelmckinsey1 self-assigned this Nov 4, 2024
@slabasan
Copy link
Collaborator

slabasan commented Nov 5, 2024

I think that's a good idea, what do you think of leading with the conference? Is there a better title to differentiate the work?

  • HPDC '23: Optimization-Based Clustering on RAJA Performance Suite
  • P3HPC '24: Clustering Analysis on RAJA Performance Suite
  • P3HPC '24: Top Down Analysis on RAJA Performance Suite

Wait, and don't we have two notebooks for P3HPC?

@dyokelson
Copy link
Collaborator

@slabasan yes, the roofline plots from P3HPC are in the ncu reader tutorial notebook, so we could point to both

(also, I agree with keeping both clustering notebooks, they are different types of clustering too)

@michaelmckinsey1
Copy link
Collaborator Author

I think that's a good idea, what do you think of leading with the conference? Is there a better title to differentiate the work?

  • HPDC '23: Optimization-Based Clustering on RAJA Performance Suite
  • P3HPC '24: Clustering Analysis on RAJA Performance Suite
  • P3HPC '24: Top Down Analysis on RAJA Performance Suite

Wait, and don't we have two notebooks for P3HPC?

395f4f8 Updates the titles for notebooks related to published work

@slabasan slabasan merged commit 8a6927d into LLNL:develop Nov 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-docs Issues and PRs related to Thicket's documentation, notebooks, and examples priority-normal Normal priority issues and PRs status-ready-for-review This PR is ready to be reviewed by assigned reviewers type-feature Requests for new features or PRs which implement new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants