Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature saxpy caliper support #114

Merged
merged 7 commits into from
Jan 17, 2024
Merged

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Jan 16, 2024

No description provided.

Copy link
Member

@daboehme daboehme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The adiak_collect_all() function replaces all of the implicit adiak calls, i.e. you can also delete the user, uid, launchdate, executable, and executablepath calls.

@pearce8 pearce8 merged commit 2f93189 into develop Jan 17, 2024
6 checks passed
@pearce8 pearce8 deleted the feature_saxpy_caliper_support branch January 17, 2024 02:17
Copy link
Collaborator Author

@rfhaque rfhaque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pearce8 One more change to consolidate adiak calls
Opened a new PR #115

adiak_cmdline();
adiak_hostname();
adiak_clustername();
adiak_collect_all();
adiak_namevalue("compiler", adiak_general, NULL, "%s", SAXPY_COMPILER_ID);
adiak_namevalue("compiler version", adiak_general, NULL, "%s", SAXPY_COMPILER_VERSION);
CALI_MARK_BEGIN("main");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daboehme The separation between "main" and "problem" is to allow for definition of other problems later on. However, if we have to remove one, can we remove "main" and keep "problem" or vice-versa?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants