Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caliper to saxpy #112

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Add caliper to saxpy #112

merged 4 commits into from
Jan 16, 2024

Conversation

rfhaque
Copy link
Collaborator

@rfhaque rfhaque commented Jan 14, 2024

No description provided.

Copy link
Collaborator

@pearce8 pearce8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the CI run failing?

@rfhaque
Copy link
Collaborator Author

rfhaque commented Jan 15, 2024

Why is the CI run failing?

@pearce8 Fixed. The license comments had a # instead of forward slashes.

@pearce8 pearce8 merged commit 5e7b9e4 into develop Jan 16, 2024
6 checks passed
@pearce8 pearce8 deleted the feature_saxpy_caliper_support branch January 16, 2024 00:44
adiak_libraries();
adiak_cmdline();
adiak_hostname();
adiak_clustername();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just use adiak_collect_all() for these

CALI_MARK_BEGIN("main");

adiak_namevalue("Problem", adiak_general, NULL, "%s", "standard");
CALI_MARK_BEGIN("problem");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the problem region is redundant since it's essentially the same as main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants