Skip to content

Fix CMake warning when looking for rocPRIM #1397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2022
Merged

Fix CMake warning when looking for rocPRIM #1397

merged 2 commits into from
Dec 5, 2022

Conversation

adayton1
Copy link
Member

@adayton1 adayton1 commented Dec 2, 2022

Summary

@adayton1
Copy link
Member Author

adayton1 commented Dec 2, 2022

Using the CMake developer guide found here: https://cmake.org/cmake/help/latest/manual/cmake-developer.7.html#standard-variable-names

rhornung67
rhornung67 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@rhornung67 rhornung67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @adayton1

@rhornung67
Copy link
Member

@MrBurmark @trws @artv3 @rchen20 anyone else want to review before we merge this?

@rhornung67 rhornung67 requested a review from MrBurmark December 5, 2022 20:03
@rhornung67 rhornung67 merged commit 49f2a79 into develop Dec 5, 2022
@rhornung67 rhornung67 deleted the bugfix/dayton8/rocprim_cmake_warning branch December 5, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbeckingsale davidbeckingsale davidbeckingsale approved these changes

@MrBurmark MrBurmark MrBurmark approved these changes

@artv3 artv3 artv3 approved these changes

@rhornung67 rhornung67 rhornung67 approved these changes

@rchen20 rchen20 rchen20 approved these changes

@trws trws Awaiting requested review from trws

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMake 3.21.1 warning on rzwhamo
6 participants
@adayton1 @rhornung67 @davidbeckingsale @MrBurmark @artv3 @rchen20