Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable type declarations #122

Merged
merged 1 commit into from
Dec 7, 2024
Merged

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Nov 28, 2024

Replaces #119

This PR adds the question mark or null to the parameter types to to avoid the deprecation warning in PHP 8.4.

This was done with the help of laravel/pint and the following configuration in the pint.json:

{
    "preset": "empty",
    "rules": {
        "nullable_type_declaration_for_default_null_value": true
    }
}

@LKaemmerling LKaemmerling merged commit aec81bb into LKDevelopment:master Dec 7, 2024
1 of 5 checks passed
@LKaemmerling
Copy link
Collaborator

LGTM thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants