This repository was archived by the owner on May 8, 2023. It is now read-only.
[WIP] Ts migration #19
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
Co-authored-by: ts-migrate <>
kamikazebr
commented
Sep 16, 2022
Comment on lines
+1
to
+24
| { | ||
| "mainEntryPointFilePath": "<projectFolder>/dist/dts/index.d.ts", | ||
| "apiReport": { | ||
| "enabled": false | ||
| }, | ||
| "docModel": { | ||
| "enabled": false | ||
| }, | ||
| "dtsRollup": { | ||
| "enabled": true, | ||
| "untrimmedFilePath": "<projectFolder>/dist/types/index.d.ts" | ||
| }, | ||
| "messages": { | ||
| "extractorMessageReporting": { | ||
| "default": { | ||
| "logLevel": "none" | ||
| }, | ||
| "ae-forgotten-export": { | ||
| "logLevel": "none" | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
No newline at end of file |
Author
There was a problem hiding this comment.
Not used yet, but could if want compress all types in one file for example.
Author
There was a problem hiding this comment.
That could be removed for now.
Contributor
|
Hey, thanks for sharing this. We're working on a TS migration that also refactors most of the SDK into smaller packages, with other improvements too. It should be out in a few weeks. Unfortunately since we're already working on it, we can't accept this PR. Really appreciate your work on this though! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Start the TS migration for the lit js sdk.
Look for that kind
@ts-expect-errorin the code to check what is ignore for ts build and may need fix the typings. See example below: In that case i choose for now just ignore.What was done
modules.d.tsandtypes.d.tsfor organizing the new types informations (may you want put the types in different folders os structure)tsconfig.jsonandtypescriptpackageHow test
Just run
npx tscand will get the types.What need to be done
@ts-expect-errorConsiderations
I hope that could help others people want use that with Typescript and inspire more people help to convert that.