-
Notifications
You must be signed in to change notification settings - Fork 80
Feature/lit 4185 js sdk naga housekeeping #790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Ansonhkg
merged 25 commits into
feat/naga-fix-bls-wasm-cleanup
from
feature/lit-4185-js-sdk-naga-housekeeping
Feb 6, 2025
Merged
Feature/lit 4185 js sdk naga housekeeping #790
Ansonhkg
merged 25 commits into
feat/naga-fix-bls-wasm-cleanup
from
feature/lit-4185-js-sdk-naga-housekeeping
Feb 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ove-all-things-marked-as-deprecated-in-jsdoc chore: remove @deprecated code
…essControlConditions`, and `validateAccessControlConditions` to `access-control-conditions` from `LitNodeClient`
…uth-helpers` from `LitNodeClient`
…uth-helpers` from `LitNodeClient`
…Chain` to `constants` package from `types` package to prevent circular dependency. (constants > schema > types)
removed: - setCustomBootstrapUrls() privatised: - _handshakeWithNode - _getRandomHexString - _sendCommandToNode - _getNodePromises - _getSessionSigByUrl - _handleNodePromises - _throwNodeError feature: - Added `EPOCH_READY_FOR_LOCAL_DEV` as constant with JsDoc
relocated: - generateSessionCapabilityObjectWithWildcards - validateAccessControlConditions - getHashedAccessControlConditions privatised: - _getWalletSig - _checkNeedToResignSessionKey - _getSessionSigByUrl - _sendCommandToNode - _signSessionKey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🔹 General Changes
@deprecated
code.DatilDev
andDatilTest
as default arguments.Note:
NagaTest
andNaga
need to be added toNETWORKS_REQUIRING_SEV
when available.🧠 LitNodeClient should now only expose the following methods:
🔹 Core Methods
connect()
🔹 Helper Methods
setDefaultMaxPrice()
getPkpAuthContext()
getMaxPricesForNodeProduct()
createCapacityDelegationAuthSig()
encrypt()
🔹 Endpoint Methods
pkpSign()
executeJs()
decrypt()
claimKeyId()
🔁 Relocations
➡ From
LitNodeClient
toaccess-control-conditions
getFormattedAccessControlConditions
getHashedAccessControlConditions
validateAccessControlConditions
➡ From
LitNodeClient
toauth-helpers
generateSessionCapabilityObjectWithWildcards
➡ From
types
toconstants
(to prevent circular dependency)LITChain
LITCosmosChain
LITEVMChain
LITSVMChain
(New dependency order:
constants
→schema
→types
)📦 lit-core
🔻 Removed:
setCustomBootstrapUrls()
🔒 Privatised:
_handshakeWithNode
_getRandomHexString
_sendCommandToNode
_getNodePromises
_getSessionSigByUrl
_handleNodePromises
_throwNodeError
✨ Feature:
EPOCH_READY_FOR_LOCAL_DEV
as a constant with JSDoc.📦 lit-node-client-nodejs
🔁 Relocated:
generateSessionCapabilityObjectWithWildcards
validateAccessControlConditions
getHashedAccessControlConditions
🔒 Privatised:
_getWalletSig
_checkNeedToResignSessionKey
_getSessionSigByUrl
_sendCommandToNode
_signSessionKey
📦 tinny
🔻 Removed:
public bareEthAuthSig
public bareSolAuthSig
this.setupBareEthAuthSig
📦 auth-browser
🔻 Removed:
encodeCallData
decodeCallResult
📦 constants
🔻 Removed:
ABI_LIT
📑 ILitNodeClient
🔗 ILitNodeClient.ts