Skip to content

Feat/suport localchain network context from shiva #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

joshLong145
Copy link

Description

  • Adds dynamic networking configuration fetching when running local-tests on localchain

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested using local-tests and confirmed full functionality on localchain and test networks

Checklist:

  • My code follows the style guidelines of this project
  • [xI have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@joshLong145 joshLong145 requested a review from Ansonhkg as a code owner June 5, 2024 22:28
@joshLong145 joshLong145 merged commit 7ccd868 into master Jun 5, 2024
4 checks passed
@joshLong145 joshLong145 deleted the feat/suport-localchain-network-context-from-shiva branch June 5, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants