refactor (window): replace raw isize window handles with self-documenting Window and custom ID types
#1494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes the
hwndfield of theWindowstruct private and updates the codebase to use the explicitWindowtype or dedicated ID structs (such asBorderId,StackbarId) instead of rawisizehandles. This makes all window management logic self-documenting, safer, and easier to maintain.Motivation & Benefits:
ReaperNotification(pub HashMap<Window, (usize, usize)>)).isizeidentifiers from related structs, introducing clear ID types.Key Refactorings:
Hiddennow holds a privateWindowfield instead ofisize.Stackbarnow uses aStackbarIdstruct that wraps aWindow.Bordernow stores aBorderIdandtracking_window: Windowinstead of raw handles.Other Notes:
Arc<str>andWsElementIdfor Workspace Element IDs #1489 and refactor(ring): stop exposingRinginternals #1491.