Confirm that withdrawal requester owns its recipient identity before registering it #1836#1843
Open
adecaro wants to merge 1 commit into
Open
Confirm that withdrawal requester owns its recipient identity before registering it #1836#1843adecaro wants to merge 1 commit into
adecaro wants to merge 1 commit into
Conversation
Signed-off-by: Angelo De Caro <adc@zurich.ibm.com>
adecaro
force-pushed
the
receivewithdrawalrequestview-fix
branch
from
7547394 to
9af154a
Compare
AkramBitar
requested changes
Jul 2, 2026
| ```mermaid | ||
| sequenceDiagram | ||
| autonumber | ||
| participant Initiator |
Contributor
There was a problem hiding this comment.
When I view this file I see the following error (see picture)
| if err != nil { | ||
| return nil, errors.Wrapf(err, "failed to build attestation message") | ||
| } | ||
| sig, err := signRecipientAttestation(context.Context(), w, message, recipientData.Identity, true) |
Contributor
There was a problem hiding this comment.
When freshPath is true and we have a remote wallet then this will fail always with error.
func signRecipientAttestation(ctx context.Context, w *token.OwnerWallet, message []byte, identity view.Identity, freshPath bool) ([]byte, error) {
if w.Remote() {
if freshPath {
return nil, errors.Errorf("remote wallet [%s] cannot attest fresh recipient identity locally", w.ID())
}
return nil, nil
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.