-
Notifications
You must be signed in to change notification settings - Fork 1
link alignment via inv_vref #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…to trim_inv_dacb_scan
…t and adc level selection
… the modification for the trim_inv_dacb_scan and adding the inv_vref script
Also sorry for bad commit history; started this before the tasks menu got refactored. Files of primary concern are app/tool/tasks/inv_vref_scan.cxx and ana/inv_vref/inv_vref_align.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great :) the file diff doesn't look too bad so no reason to apologize.
Are you interested in converting this logic into C++ anytime soon? I think that is the next step so the tuning can be automated and run without having to create intermediate files.
Interesting! Well, I'll merge this and you can write another fix for these weird outliers. I wonder if its worth looking at checking a few points "around" the target to see if we can auto-detect this outlier behavior. |
Yea, it looks like it "gets messy" when the value is at an extreme causing ADC "saturation" (quotes because made up, not really sure whats happening electronically). The grouping in the linear regime is pretty well defined without any far outliers at zero for example. |
Modified inv_vref scan to only scan over one selected channel in each link. Added inv_vref_align.py in ana/inv_vref to take the results of this scan and find the optimal inv_vref value for each link to attain a target adc. (also changed my old trim_inv scan and algorithm to incorporate dacb similar to Chelsea's algorithm, although this isn't really pressing since we already have a method to level pedestals).