only fetch acts and compile it if not found in image

[tomeichlersmith]

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This does not have a corresponding issue here. I am following up with LDMX-Software/dev-build-context#115 while preparing for a v5 release of the ldmx/dev image.

Check List

• I successfully compiled ldmx-sw with my developments. I test compiled with the newer image that has Acts locally. The CI will check that these developments work with the v4.2.2 image that does not have Acts.
• I read, understood and follow the coding rules.
• I ran my developments and the following shows that they are successful.

The CI checks that an image without Acts can still compile and run.
I can show that this works with the newer image candidate that has Acts built in.

tom@appa:~/code/ldmx/ldmx-sw$ just use ldmx/dev:5.0.0-rc1
denv config image ldmx/dev:5.0.0-rc1
tom@appa:~/code/ldmx/ldmx-sw$ just configure
git fetch --tags && git describe --tags | cut -f 1 -d '-' > VERSION
denv cmake -B build -S . -DADDITIONAL_WARNINGS=ON -DENABLE_CLANG_TIDY=ON 
[ INFO ]: Building all modules.
[ INFO ]: Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") found components: log 
[ INFO ]: Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") found components: system log filesystem thread chrono atomic regex 
[ INFO ]: Deduced git SHA: 06e0b4dcde035ef689ab83b104b0f5f89d212c49
[ INFO ]: Building ROOT dictionary LinkDef
Looking for libboost_python
[ INFO ]: Building the modules necessary for the reconstruction.
[ INFO ]: Found ONNX Runtime version 
[ INFO ]: Found Acts 36.0.0
[ INFO ]: Found Geant4 version 10.2.3
[ INFO ]: Building the modules necessary for the simulation.
[ INFO ]: Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found version "1.83.0") found components: log 
[ INFO ]: Found Boost: /usr/lib/x86_64-linux-gnu/cmake/Boost-1.83.0/BoostConfig.cmake (found suitable version "1.83.0", minimum required is "1.68") found components: iostreams 
[ INFO ]: Installing all field map files.
-- Configuring done (0.7s)
-- Generating done (0.5s)
-- Build files have been written to: /home/tom/code/ldmx/ldmx-sw/build

[tvami]

Isn't the solution to move those virtual destructors to be non virtual (even tho they are supposed to be virtual but given that ACTS didnt do them virtual...)?

[tomeichlersmith]

That would be the solution, but that would involve editing Acts and I do not want to do that. There are also other warnings (turned errors) from Acts that are seen by the compiler that we are ignoring with the same SYSTEM strategy. I'm just localizing the SYSTEM include to be more specific.

ldmx-sw/CMakeLists.txt

Line 39 in 79fcb61

include_directories(SYSTEM Tracking/acts/Core/include)

[tvami]

Yeah I agree that editing ACTS is beyond what we should do, but the earlier warning I saw in your original commit were about the inherited class which we have control over. It's true that I didnt look at the full list, so maybe there is some stuff that we have no control over... in that case going back to the SYSTEM approach is fine