Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve memory sloppyness and solidify Python access #1173

Merged
merged 6 commits into from
Jun 22, 2023

Conversation

tomeichlersmith
Copy link
Member

@tomeichlersmith tomeichlersmith commented Jun 20, 2023

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

This resolves an issue seen when testing the updated OS image. LDMX-Software/dev-build-context#59

Check List

  • I successfully compiled ldmx-sw with my developments
    • v3.5.0 <- tested by CI
    • v3.4.0
    • v3.3
    • v3.2 (with -DBUILD_DETECTORID_BINDINGS=OFF)
    • v3.1 (with -DBUILD_DETECTORID_BINDINGS=OFF)
    • v3.0 (with -DBUILD_DETECTORID_BINDINGS=OFF)
  • I ran my developments and the following shows that they are successful.
    • successful means passing the tests in this case
  • I attached any sub-module related changes to this PR.

Related Sub-Module PRs

@tomeichlersmith tomeichlersmith marked this pull request as ready for review June 20, 2023 22:35
@EinarElen
Copy link
Contributor

On the tracing feature, I feel that ends up making an already relatively hard to read part of our codebase even harder. Would doing something like what I did in LDMX-Software/Framework#66 be an alternative?

@tomeichlersmith
Copy link
Member Author

That's a good point - it does make the code pretty messy looking. I can implement the update you suggested to replace the tracing option.

@tomeichlersmith tomeichlersmith marked this pull request as draft June 21, 2023 13:44
@tomeichlersmith tomeichlersmith marked this pull request as ready for review June 22, 2023 15:24
@tomeichlersmith tomeichlersmith merged commit 6cae411 into trunk Jun 22, 2023
@tomeichlersmith tomeichlersmith deleted the docker-59-debug-build branch June 22, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants