Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onnx runtime update #1170

Merged
merged 5 commits into from
Jun 16, 2023
Merged

onnx runtime update #1170

merged 5 commits into from
Jun 16, 2023

Conversation

tomeichlersmith
Copy link
Member

  • add API translation into ONNX ldmx-sw interface
  • update cmake infrastructure for onnx

I am updating ldmx-sw, here are the details. I am strictly depending on #1157

What are the issues that this addresses?

This helps clear the way for LDMX-Software/dev-build-context#57

Check List

  • I successfully compiled ldmx-sw with my developments (letting github figure this out for me)
  • I ran my developments and the following shows that they are successful. Compiling is enough given how small of a rename this API change was.
  • I attached any sub-module PRs

Related Sub-Module PRs

@tomeichlersmith tomeichlersmith mentioned this pull request Jun 16, 2023
Closed
3 tasks
@tomeichlersmith
update cmake to rebased ref
b94f20f 
no need for ORT version deduction in cmake

ORT_API_VERSION in C-preprocessor signals API changes for us
@tomeichlersmith
use pre-processor definition provided by ONNX
f2d8cdd
@tomeichlersmith
cmake to rebased commit
66c5f0b
@tomeichlersmith tomeichlersmith marked this pull request as ready for review June 16, 2023 17:28
@tomeichlersmith tomeichlersmith merged commit ad86bf8 into trunk Jun 16, 2023
@tomeichlersmith tomeichlersmith deleted the onnx-runtime-update branch June 16, 2023 20:18
@tomeichlersmith tomeichlersmith mentioned this pull request Aug 3, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tomeichlersmith