install nlohmann/json from package like ROOT does #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am adding a new package to the container, here are the details.
ROOT will build in nlohmann/json if it is not available already and we want a JSON reader/writer anyways, so I'm installing it from Ubuntu repos like ROOT does in its official images.
What new packages does this PR add to the development image?
Check List
ICI successfully built the container using dockerICI was able to build ldmx-sw using this new container buildICI was able to test run a small simulation and reconstruction inside this containerI wanted to make sure that we could use
find_package
in ldmx-sw to deduce if nlohmann/json is available.If it isn't, we could then use
FetchContent
to make sure that ldmx-sw can still be built with older images.Added a line to
ldmx-sw/CMakeLists.txt
:which gives (when running
just configure
afterjust use ldmx/dev:global-install-nlohmann-json
):