-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Building CI to track ldmx-sw #109
Conversation
Alright, the test infrastructure is working as intended, but I have only been testing with ldmx/dev:latest (i.e. 4.2.2). After the latest build (https://github.com/LDMX-Software/dev-build-context/actions/runs/13638466534) finishes, I'll update to test run with |
310c234
to
e57454f
Compare
The minimum supported ldmx-sw version (MSLV) for this image is now v3.3.0. Technically, we could go lower if we don't build The ldmx-sw versions <= v3.2.12 are old enough that I think we don't need to support development off of them anymore. We already have instructions for pushing developers to develop off of v4 anyways so I'm okay with bumping the MSLV from v3.0.0 to v3.3.0. |
manually update v4 versions, intentionally leave the latest version old so the dependabot can be tested on main
c81e8c6
to
10d6f82
Compare
This resolves #104
git diff
rather than scriptshave the AMD build happen on GitHub runners? <- not sure if I want to make this work but it is technically feasiblewon't dodenv
for test building ldmx-swjust
as well so we respect the recipes in the justfile and don't have to update stuff here when testingI did test runs of
./ci/test-ldmx-sw
locally and it works. With the other builds happening right now (and the layer caching being broken I think?), the CI tests on GitHub were cancelled after waiting too long to be run.