Correcting for a missing gain factor in the noise image creation#133
Open
gterreran wants to merge 3 commits intoLCOGT:masterfrom
Open
Correcting for a missing gain factor in the noise image creation#133gterreran wants to merge 3 commits intoLCOGT:masterfrom
gterreran wants to merge 3 commits intoLCOGT:masterfrom
Conversation
Collaborator
|
Thanks for catching this @gterreran! Can you please let us know how you tested this PR and what we should do to test it? |
Contributor
Author
|
I asked Megan to test it by trying to do an image subtraction with PS1. You can probably do the same. |
Collaborator
|
@gterreran you are much more familiar with the problem, what looks wrong, and what looks right. Please provide a detailed test plan (e.g. what commands to run and how to tell if the bug is fixed from the output). PR #132 has an example. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the noise image was created, a few missing gain factor were missing.
Since the noise image is created at least in two instances, I created a separate function. I also added some comments to make it more readable.
The gain for Sinistro should be 1, so even with this bug, previous LCO-LCO subtractions should not have been affected. However subtraction using other surveys might have.