-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TS-1501] extend AssetContract with additional fields #78
Merged
LBHJHeppinstall
merged 7 commits into
main
from
feature/ts-1501-extend-contract-with-approval-fields
Jul 11, 2024
Merged
[TS-1501] extend AssetContract with additional fields #78
LBHJHeppinstall
merged 7 commits into
main
from
feature/ts-1501-extend-contract-with-approval-fields
Jul 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LBHTKarki
reviewed
Jul 10, 2024
LBHTKarki
reviewed
Jul 10, 2024
LBHTKarki
reviewed
Jul 10, 2024
LBHTKarki
reviewed
Jul 10, 2024
LBHTKarki
reviewed
Jul 10, 2024
adamtry
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket
https://hackney.atlassian.net/browse/TS-1501
Describe this PR
What is the problem we're trying to solve
This is part of the work to extend
housing-search-api
to return additional contract data along with the search search results. The additional data will be used for the Contracts Worktray.What changes have we introduced
AssetContract
has been extended to contain the additional fieldsstartDate
,approvalDate
,isApproved
andrelatedPeople
.The preview package has been tested successfully in housing search listener.
Follow up actions after merging PR
n/a