Fix MutliPart Generator random Engine

[bear-is-asleep]

Update multipart generator to have engines run without segmentation faults. Segmentation faults occur in SBND without this patch.

@LauPM can you check this?

[FNALbuild]

A new Pull Request was created by @bear-is-asleep (Bear Carlson) for develop.

It involves the following packages:

larsim

@LArSoft/level-1-managers, @LArSoft/level-2-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[knoepfel]

@bear-is-asleep, the reason for the segfault is that the variable bool _cosmic_distribution is initialized after it is used for the first time.

The best fix would be to initialize _cosmic_distribution in the initialization list of the module:

MultiPartRain::MultiPartRain(fhicl::ParameterSet const& p)
  : EDProducer(p)
  , fFlatEngine(art::ServiceHandle<rndm::NuRandomService>()->registerAndSeedEngine(
      createEngine(0, "HepJamesRandom", "GenRain"),
      "HepJamesRandom",
      "GenRain"))
  , _cosmic_distribution{p.get<bool>("CosmicDistribution", false)} // <== Initialize before use
{
 // ... a bunch of code that can now use _cosmic_distribution
}

[bear-is-asleep]

, _cosmic_distribution{p.get<bool>("CosmicDistribution", false)}

It successfully builds locally after the most recent commit. Thank you for the suggestion!

[knoepfel]

, _cosmic_distribution{p.get<bool>("CosmicDistribution", false)}

It successfully builds locally after the most recent commit. Thank you for the suggestion!

No problem. Actually, that one change should be sufficient to resolve the segfault—you shouldn't need the other commits. Can you adjust this PR to contain only the change in initializing the Boolean variable?

[bear-is-asleep]

ge in initializing the Boolean variable?

, _cosmic_distribution{p.get<bool>("CosmicDistribution", false)}

It successfully builds locally after the most recent commit. Thank you for the suggestion!

No problem. Actually, that one change should be sufficient to resolve the segfault—you shouldn't need the other commits. Can you adjust this PR to contain only the change in initializing the Boolean variable?

Ah I got it, just updated the PR to only use the boolean. I checked and it locally builds and runs.

[lgarren]

trigger build

[FNALbuild]

The tests are being triggered in jenkins.

[FNALbuild]

Pull request #162 was updated. @LArSoft/level-2-managers, @LArSoft/level-1-managers can you please check and sign again.

[FNALbuild]

The code-checks are being triggered in jenkins.

[FNALbuild]

+code-checks

[FNALbuild]

+LArSoft tests OK on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28129&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

[FNALbuild]

+LArSoft tests OK on slf7 for c14:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:LArSoft/view_builds/index?offset=0&builds=lar_ci/28130&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=&builds=

[FNALbuild]

-ICARUS tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/13300&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28129&builds=

[FNALbuild]

-uBooNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:uBooNE/view_builds/index?offset=0&builds=uboone_ci/12949&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28129&builds=

[FNALbuild]

-SBND tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/18852&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28129&builds=

[FNALbuild]

-DUNE tests failed on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:DUNE/view_builds/index?offset=0&builds=dune_ci/20266&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/28129&builds=

[lgarren]

approve

[FNALbuild]

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.