[WIP] Lasy GPU implementation #437
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Weekly Code Coverage Update
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| # Set right FFT functions | ||
| if inverse: | ||
| xfftshift = np.fft.ifftshift | ||
| xfftshift = xp.fft.ifftshift |
Check notice
Code scanning / CodeQL
Unused local variable Note
| # Set right FFT functions | ||
| if inverse: | ||
| xfftshift = np.fft.ifftshift | ||
| xfftshift = xp.fft.ifftshift |
Check notice
Code scanning / CodeQL
Unused local variable Note
| laser_3d.dim, laser_3d.grid, 2.0 * xp.pi / 0.6e-6 | ||
| ) | ||
| [beta_x, beta_y] = get_beta(laser_3d.dim, laser_3d.grid, 2.0 * np.pi / 0.6e-6) | ||
| [beta_x, beta_y] = get_beta(laser_3d.dim, laser_3d.grid, 2.0 * xp.pi / 0.6e-6) |
Check notice
Code scanning / CodeQL
Unused global variable Note test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant change to the
lasycodebase by replacingnumpywith a backend abstraction (xp) that defaults tocupyif available, enabling GPU acceleration. Additionally, it updates workflow configurations and adds a coverage badge. Below is a summary of the most important changes grouped by theme.Backend abstraction for GPU acceleration:
lasy/backend.py, introducing thexpabstraction that defaults tocupyfor GPU acceleration and falls back tonumpyifcupyis unavailable. (lasy/backend.py, lasy/backend.pyR1-R10)numpyoperations across multiple files to usexp, including mathematical functions (xp.sqrt,xp.exp, etc.), array manipulations (xp.meshgrid,xp.concatenate), and interpolations. (lasy/laser.py, [1] [2] [3] [4] [5] [6];lasy/optical_elements/*, [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23];lasy/profiles/*, [24] [25] [26] [27] [28] [29]