-
Notifications
You must be signed in to change notification settings - Fork 38
add speckled lasers to LASY #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RemiLehe
merged 56 commits into
LASY-org:development
from
RTSandberg:feature-speckle-lasers
Apr 12, 2024
Merged
add speckled lasers to LASY #221
RemiLehe
merged 56 commits into
LASY-org:development
from
RTSandberg:feature-speckle-lasers
Apr 12, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Some questions I had:
|
RemiLehe
reviewed
Feb 7, 2024
for more information, see https://pre-commit.ci
a268d6a to
6af71ce
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RemiLehe
reviewed
Feb 13, 2024
Member
RemiLehe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only had time to go through about half of the PR, but I wanted to already post the comments I had so far.
Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
RemiLehe
reviewed
Apr 5, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…nto feature-speckle-lasers
02f5610 to
40cd028
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
RemiLehe
approved these changes
Apr 12, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds speckled lasers to LASY for studying laser-plasma interactions and ICF