Skip to content

Conversation

@RTSandberg
Copy link
Contributor

This PR adds speckled lasers to LASY for studying laser-plasma interactions and ICF

@AngelFP AngelFP added the new feature request or implementation of a new feature label Jan 15, 2024
@RTSandberg RTSandberg requested a review from RemiLehe February 1, 2024 19:40
@RTSandberg
Copy link
Contributor Author

Some questions I had:

  • The interface is a bit inconsistent between 2-tuples and 2-lists, is there a preference for one v. the other?
  • Is there value in using Enums for valid smoothing types?
    I like some a programmatic way of identifying, listing, accessing, and using valid types, but maybe a list of available types is sufficient?
  • Is it desirable to just have RPP/CPP, no temporal motion of speckles?
  • The equation in readthedocs is too long, is there a way to do multi-line equations?
  • The speed of light c is currently hardcoded in at low precision, what is the desired way to include c?
  • The testing is not very systematic; are the provided tests sufficient? Is it desirable to be more comprehensive over smoothing types and asymmetric parameter choices in the tests?
  • There are certain unused parameters such as cep, z_foc, etc. How do we want to deal with these?

@RTSandberg RTSandberg changed the title [WIP] add speckles to LASY add speckled lasers to LASY Feb 1, 2024
@RemiLehe RemiLehe self-assigned this Feb 5, 2024
@RTSandberg RTSandberg force-pushed the feature-speckle-lasers branch from a268d6a to 6af71ce Compare February 8, 2024 17:11
Copy link
Member

@RemiLehe RemiLehe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only had time to go through about half of the PR, but I wanted to already post the comments I had so far.

Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
@RemiLehe RemiLehe force-pushed the feature-speckle-lasers branch 2 times, most recently from 02f5610 to 40cd028 Compare April 5, 2024 18:19
@RemiLehe RemiLehe merged commit e653cb2 into LASY-org:development Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new feature request or implementation of a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants