suggestions: Suggestions for renamed items#196
Merged
mhovd merged 4 commits intofeat/normalized-row-apifrom Jan 21, 2026
Merged
suggestions: Suggestions for renamed items#196mhovd merged 4 commits intofeat/normalized-row-apifrom
mhovd merged 4 commits intofeat/normalized-row-apifrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames and reorganizes the data parsing infrastructure to better reflect its generic, format-agnostic nature. The changes move from Pmetrics-specific naming to more general terminology.
Changes:
- Renamed
NormalizedRowtoDataRowandNormalizedRowBuildertoDataRowBuilderto better reflect their format-agnostic purpose - Renamed
PmetricsErrortoDataErrorand moved it fromparser/pmetrics.rstorow.rsto reflect its broader scope - Moved the row module from
data/parser/normalized.rstodata/row.rsas a standalone module - Updated all imports, exports, and references throughout the codebase to use the new naming
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Updated prelude exports to use DataRow and DataRowBuilder instead of NormalizedRow and NormalizedRowBuilder |
| src/error/mod.rs | Changed error variant from PmetricsError to DataError and updated import path to crate::data::row::DataError |
| src/data/row.rs | Renamed NormalizedRow to DataRow, NormalizedRowBuilder to DataRowBuilder, and moved DataError from pmetrics module; updated all documentation and test references |
| src/data/parser/pmetrics.rs | Removed PmetricsError definition (moved to row.rs), updated imports to use DataError and DataRow, renamed to_normalized() to to_datarow() |
| src/data/parser/mod.rs | Removed normalized module, updated re-exports to use crate::data::row for DataRow, DataRowBuilder, and build_data |
| src/data/mod.rs | Added row module declaration |
Comments suppressed due to low confidence (1)
src/data/row.rs:563
- There's a grammatical error in the error message. "Observation OUTEQ is missing in for" should be "Observation OUTEQ is missing for" (remove "in").
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Siel
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.