Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Clippy lint warnings by making the code more idiomatic and concise. The changes include adding the is_empty() method to the Weights struct and simplifying loop patterns used in algorithm execution.
Changes:
- Added
is_empty()method toWeightsstruct to complement existinglen()method - Refactored algorithm fitting loops from explicit match statements to more concise
while letpatterns - Simplified return statement in
fit()method by removing redundantOk()wrapper
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/structs/weights.rs | Added is_empty() method to satisfy Clippy's len_without_is_empty lint |
| src/bestdose/posterior.rs | Refactored NPAG optimization loop to use while let pattern instead of explicit match |
| src/algorithms/mod.rs | Refactored algorithm fitting loop and simplified return statement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
| Branch | clippy |
| Testbed | mhovd-pgx |
⚠️ WARNING: No Threshold found!Without a Threshold, no Alerts will ever be generated.
Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the--ci-only-thresholdsflag.
Click to view all benchmark results
| Benchmark | Latency | milliseconds (ms) |
|---|---|---|
| bimodal_ke_npag | 📈 view plot | 5,076.00 ms |
| bimodal_ke_npod | 📈 view plot | 1,664.50 ms |
| bimodal_ke_postprob | 📈 view plot | 429.39 ms |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor changes