Conversation
Contributor
|
Bencher Report| Branch | bestdose |
| Testbed | pmcore-runner |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result seconds (s) (Result Δ%) | Upper Boundary seconds (s) (Limit %) |
|---|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold | 33.84 s(+48.09%)Baseline: 22.85 s | 49.31 s (68.62%) |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 43.79 s(+83.72%)Baseline: 23.84 s | 70.38 s (62.22%) |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 15.17 s(+82.82%)Baseline: 8.30 s | 24.41 s (62.14%) |
Contributor
|
| Branch | bestdose |
| Testbed | rust-loki |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result seconds (s) (Result Δ%) | Upper Boundary seconds (s) (Limit %) |
|---|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold | 42.03 s(+18.60%)Baseline: 35.44 s | 43.61 s (96.37%) |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 56.08 s(+20.53%)Baseline: 46.53 s | 60.95 s (92.02%) |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 19.20 s(+19.28%)Baseline: 16.10 s | 20.82 s (92.24%) |
Member
|
We might need to merge main again into this branch so the tests pass |
Co-Authored-By: Julian Otalvaro <1023006+Siel@users.noreply.github.com> Co-Authored-By: masyamada <walter.mas.yamada@gmail.com>
Co-Authored-By: Julian Otalvaro <1023006+Siel@users.noreply.github.com>
Co-Authored-By: Julian Otalvaro <1023006+Siel@users.noreply.github.com>
Next is updating the cost function to use all predictions
Warning: The new approach is more computationally expensive
Member
|
Before merging this branch, it needs more work to support multiple output equations |
Contributor
|
| Branch | bestdose |
| Testbed | rust-moan |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result seconds (s) (Result Δ%) | Upper Boundary seconds (s) (Limit %) |
|---|---|---|---|
| bimodal_ke_npag | 📈 view plot 🚷 view threshold | 24.80 s(-1.98%)Baseline: 25.30 s | 26.43 s (93.82%) |
| bimodal_ke_npod | 📈 view plot 🚷 view threshold | 10.58 s(+0.60%)Baseline: 10.52 s | 10.76 s (98.34%) |
| bimodal_ke_postprob | 📈 view plot 🚷 view threshold | 3.50 s(+0.37%)Baseline: 3.48 s | 3.55 s (98.44%) |
Member
|
@mhovd All bugs are now fixed. in my opinion this is ready to be merged |
Collaborator
Author
* Documentation * Make fields of BestDoseProblem private and rename field * Rename fields * Change output of result * Update tests --------- Co-authored-by: Julian Otalvaro <juliandavid347@gmail.com>
* Clean up result structure * Remove redundant code * Remove clone * Update bestdose.rs * Use enum for optimization method * Enum for the status of BestDose
Siel
approved these changes
Nov 5, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.