improving HDT

[swannie-eire]

fixing source flag
updating module to mod existing torrent instead of downloading as a lot less can go wrong.

[swannie-eire]

Please let me double check this works ok before merging as someone reported an issue

[swannie-eire]

this can be merged. works on all my tests.

Admins want the description updated. I will take care of that next week.

@sirius-sama can you check again its working for you. I never updated the example config with the my_announce field and thats why it failed for you

[sirius-sama]

Sorry, I didn't reply here before. All are working fine. (In case L4G is waiting for my response before approval)

[L4GSP1KE]

Sorry, I've been really busy. What's the reasoning behind adding my_announce_url to the config vs using the announce_url that seems to exist in the config already?

[swannie-eire]

Sorry, I've been really busy. What's the reasoning behind adding my_announce_url to the config vs using the announce_url that seems to exist in the config already?

These are different.
announce_url is the generic announce url which is required to upload to site- "https://hdts-announce.ru/announce.php"
my_announce_url is the users personal announce url with passkey which is needed to seed the torrent from client. "https://hdts-announce.ru/announce.php?pid=<PASS_KEY/PID>"

Unlike other trackers where you can upload a torrent with your personal announce url(with passkey) in it on HDT that will result in an error. You need to upload with the generic announce_url and then you can add your announce+passkey to the torrent in your client or download the torrent from HDT with your personal announce url(with passkey).

Make sense?

theres is a few options i could think of here.

1. The generic announce url can be hardcoded into the HDT module and announce_url in config can just contain the users personal announce.
2. have a field in config for passkey and pass the generic_url + passkey when adding the torrent instead of having my_announce_url
3. separate announce field for users personal announce. current implementation

i dont mind what you choose or if you think of a better way.

[L4GSP1KE]

@swannie-eire Just took a second look and it seems like the announce_url config value is not used. Can we use this value with what you have as my_announce_url, or just require passkey? Also description updates were mentioned, feel free to throw them in with these or make a new PR later.

Thanks for your continued contributions and putting up with me being extra slow.

[swannie-eire]

@L4GSP1KE announce_url It is used in the edit_torrent function which is called from the HDT module on line 118.

you use that function to create all torrents for upload. Unfortunately for HDT you have to create with generic announce and then add your own announce afterwards.

https://github.com/L4GSP1KE/Upload-Assistant/blob/cef45b659076965246deccec919c05714df559cd/src/trackers/COMMON.py

I wont have time to look at the description for a few weeks at the earliest so i would go ahead and merge this. I have been having a few weeks of hell with raid array dying days after i deleted all backups off g-drive as i was trying to get within their new storage limits. When it rains it pours.

In future if i add trackers do you want me to try to keep custom functions like "add_tracker_torrent" in the tracker module. Im just trying to follow your lead by putting it in common since thats where you have torrent edit functions. I only started to teach myself to code last year so dont really have any professional experience. I just try to copy what i see others do whether thats right or wrong i dont know.