Remove the shopOrigin from the appBridge
#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tdated error" when used alongside `host`
|
This would be HUGE. I am not a good enough dev to really help with making this work but rooting for you guys on the sideline. |
|
Even though it won't be universally enforced until 9/6/2023, I believe that on 1/31/2023 all merchants will have access to the |
|
As of today it seems Shopify isn't approving any new apps without this change, which makes this quite important. |
Owner
Author
|
I'll fix the tests on this ticket this weekend and get a release version out asap. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
shopOriginfrom the appBridge config as it throws an "outdated error" when used alongsidehost