App keep loading after removing shopOrigin in 17.4.0

[yasir-naseer]

For bug reporting only! If you're posting a feature request or discussion, please ignore.

Expected Behavior

The app should load fine in Iframe after installation

Current Behavior

When i install the app, the app keeps loading and im getting alot of error logs in console regarding app bridge

Failure Information

I have setup a fresh shopify app, with the latest commit where shopOrigin was removed and other changes where made, but seems like when i install the app, the app keeps loading and im getting alot of error logs in console regarding app bridge

Steps to Reproduce

Please provide detailed steps for reproducing the issue.

1. Install fresh laravel app
2. use the latest package version
3. Install the app

Context

• Package Version: 17.4.0
• Laravel Version: 7.30.6
• PHP Version: 7.4.32
• Template Engine: Blade

Failure Logs

[yasir-naseer]

i checked the app bridge configuration, seems like the host parameter is not getting picked

[Kyon147]

Hi @yasir-naseer

This can be fixed by moving to 17.4.1 as the issue was on the blade template version where the auth token redirect that happens never got the host param from the VerifyShopify middleware redirect.

[jackwefullfill]

hi @Kyon147

so for now, blade templates still have to use shopOrigin right?

[Kyon147]

Hi @jackwefullfill

17.4.1 still uses host it just fixes a bug where it was not being passed through the auth properly. shopOrigin is no longer used as it is being deprecated by Shopify.

[jackwefullfill]

hi @Kyon147 , thanks for the explanation, so what I wanted to ask is that in order to use the blade template, we need to wait for the 17.4.1 version release. only then the app will become compatible new shopify domain right?

[Kyon147]

Yeah that is right, 17.4.1 will be compatible with the new admin domain but will also work for the older domain too.

[yasir-naseer]

hi @Kyon147

after upgrading to 17.4.1. The issue of app not loading is fixed, since now im getting the host parameter in app bridge setup (which is all good now)

but when i redirect to some other page, the host parameter is lost again and the app starts keep loading, am i missing something?

Here is how my tag look like

<a class="nav-link" href="{{ \Illuminate\Support\Facades\URL::tokenRoute('home') }}" >Home</a>

153f5f3d-d7f7-49a1-b35d-0b6e9c389d8d.webm

[Kyon147]

@yasir-naseer Shopify have explicitly said, if you are running a multipage app you need to manually pass the host param to all pages.

The package does not do this automatically, so you will need to remember to pass to host from page to page.