[SPARK-38631][CORE] Uses Java-based implementation for un-tarring at … #645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Utils.unpack
What changes were proposed in this pull request?
This PR proposes to use
FileUtil.unTarUsingJava
that is a Java implementation for un-tar.tar
files.unTarUsingJava
is not public but it exists in all Hadoop versions from 2.1+, see HADOOP-9264.The security issue reproduction requires a non-Windows platform, and a non-gzipped TAR archive file name (contents don't matter).
Why are the changes needed?
There is a risk for arbitrary shell command injection via
Utils.unpack
when the filename is controlled by a malicious user. This is due to an issue in Hadoop'sunTar
, that is not properly escaping the filename before passing to a shell command:https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileUtil.java#L904Does this PR introduce any user-facing change?
Yes, it prevents a security issue that, previously, allowed users to execute arbitrary shall command.
How was this patch tested?
Manually tested in local, and existing test cases should cover.
Closes apache#35946 from HyukjinKwon/SPARK-38631.
Authored-by: Hyukjin Kwon gurwls223@apache.org
(cherry picked from commit 057c051)
What changes were proposed in this pull request?
Why are the changes needed?
Does this PR introduce any user-facing change?
How was this patch tested?