Skip to content

fix size of ColumnBuffer not configurable#396

Merged
liuneng1994 merged 1 commit into
Kyligence:clickhouse_backendfrom
shuai-xu:bugfix
Apr 6, 2023
Merged

fix size of ColumnBuffer not configurable#396
liuneng1994 merged 1 commit into
Kyligence:clickhouse_backendfrom
shuai-xu:bugfix

Conversation

@shuai-xu
Copy link
Copy Markdown

@shuai-xu shuai-xu commented Apr 3, 2023

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

The buffer size of ColumnBuffer is now hard code to 8192, let it be the same as Option.buffer_size.

@kyligence-git
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

Copy link
Copy Markdown

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 5d0e686 into Kyligence:clickhouse_backend Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants