Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge development branch (Sourcery refactored) #84

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Feb 18, 2022

Pull Request #82 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the dev/development branch, then run:

git fetch origin sourcery/dev/development
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from KyleKing February 18, 2022 03:59
@sourcery-ai sourcery-ai bot force-pushed the sourcery/dev/development branch from 9d70edf to 5d99392 Compare February 18, 2022 13:41
@sourcery-ai sourcery-ai bot force-pushed the sourcery/dev/development branch from 5d99392 to 91922d2 Compare February 18, 2022 13:56
if path_file.is_file():
return path_file.read_text().split('\n')
return []
return path_file.read_text().split('\n') if path_file.is_file() else []
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function read_lines refactored with the following changes:

return f'{foreground}{task_summary.name} {exit_summary}' + fg.rs
return f'{foreground}{task_summary.name} {exit_summary}{fg.rs}'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function _format_task_summary refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Feb 18, 2022

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.14%.

Quality metrics Before After Change
Complexity 1.22 ⭐ 1.23 ⭐ 0.01 👎
Method Length 33.13 ⭐ 33.04 ⭐ -0.09 👍
Working memory 5.27 ⭐ 5.29 ⭐ 0.02 👎
Quality 87.16% 87.02% -0.14% 👎
Other metrics Before After Change
Lines 278 276 -2
Changed files Quality Before Quality After Quality Change
calcipy/file_helpers.py 85.74% ⭐ 85.44% ⭐ -0.30% 👎
calcipy/doit_tasks/summary_reporter.py 89.17% ⭐ 89.18% ⭐ 0.01% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@KyleKing KyleKing merged commit a14c854 into dev/development Feb 18, 2022
@KyleKing KyleKing deleted the sourcery/dev/development branch February 18, 2022 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant