Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the max total rows of the tables and add pagination #1739

Merged
merged 7 commits into from
Dec 14, 2022

Conversation

LeifuChen
Copy link
Contributor

@LeifuChen LeifuChen commented Dec 12, 2022

Description

To meet the new requirements of the escrow table, we made the following changes:

  1. Increase the maximum number of total rows from 1000 to 9999.
  2. Add pagination

Related issue

Motivation and Context

Show all the rows of escrow entries

How Has This Been Tested?

  1. Open a watch-only wallet with kethic.eth
  2. Scroll down to the bottom
  3. See the pagination (11 pages) correctly

Screenshots (if appropriate):

image

@vercel
Copy link

vercel bot commented Dec 12, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
kwenta ✅ Ready (Inspect) Visit Preview Dec 14, 2022 at 0:37AM (UTC)

@vercel vercel bot temporarily deployed to Preview December 12, 2022 19:39 Inactive
@LeifuChen LeifuChen marked this pull request as ready for review December 12, 2022 19:45
@vercel vercel bot temporarily deployed to Preview December 13, 2022 18:53 Inactive
@vercel vercel bot temporarily deployed to Preview December 13, 2022 19:27 Inactive
@vercel vercel bot temporarily deployed to Preview December 13, 2022 20:07 Inactive
platschi
platschi previously approved these changes Dec 13, 2022
@vercel vercel bot temporarily deployed to Preview December 14, 2022 00:30 Inactive
@vercel vercel bot temporarily deployed to Preview December 14, 2022 12:37 Inactive
@platschi platschi merged commit 5af5a6d into dev Dec 14, 2022
@platschi platschi deleted the fix/escrow-table-pagination branch March 22, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants