Futures market key update #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
platschi
pushed a commit
that referenced
this pull request
Dec 12, 2022
* Futures refactor continued * Refactor isolated margin transfer actions * Refactor balances * Refactor futures data polling * Refactor orders and cross margin settings queries * Multicall contract updates * get positions by account type * fetch all positions when provider ready * fix initial position fetch * Simplify polling pattern * use market keys to index (#1712) use market keys to index * Refactor isolated margin actions * Move close isolated margin position to sdk and redux * Refactor trade previews * Fix cross margin leverage * Improve cross margin preview speed * Refactor trade inputs * Fix shorts and dashboard orders count * Futures refactor continued * fix trade preview on position side change * Clean up * Update state/balances/selectors.ts Co-authored-by: troyb.eth <me@troyb.xyz> Co-authored-by: Troy <troy.burmeister@gmail.com> Co-authored-by: troyb.eth <me@troyb.xyz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the futures refactor by using the
marketKeyas an index instead of themarketAsset.Description
marketAsset -> marketKeyis a "one-to-many" since we will have a V1 and V2 market with the same asset (sETH). Start migrating the UI to use themarketKeyas the unique index for markets and positions.