Skip to content

State: add field 'cluster' in State #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

SparkYuan
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/states/

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Add field 'cluster' in State as a logical concept to separate states in one stack

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add field 'cluster' in State as a logical concept to separate states in one stack

@SparkYuan SparkYuan added this to the v0.6.0 milestone Jul 11, 2022
@SparkYuan SparkYuan requested a review from a team July 11, 2022 13:50
@SparkYuan SparkYuan requested a review from a team July 11, 2022 13:50
@SparkYuan SparkYuan changed the title State: add 'cluster' field in State State: add field 'cluster' in State Jul 11, 2022
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 72.467% when pulling cdc6eb7 on SparkYuan:update_state into 9ba14e2 on KusionStack:main.

Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm

Copy link
Collaborator

@howieyuen howieyuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name cluster may not only indicate cluster, a little confused, may need some scenario to prove it

@SparkYuan SparkYuan merged commit 182d162 into KusionStack:main Jul 12, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
@SparkYuan SparkYuan deleted the update_state branch June 26, 2023 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants