Skip to content

feat: three way diff, compare live config with dry-run result #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

feat: three way diff, compare live config with dry-run result #91

merged 1 commit into from
Jul 12, 2022

Conversation

howieyuen
Copy link
Collaborator

related issue: #51

@howieyuen howieyuen requested review from a team July 7, 2022 03:45
@coveralls
Copy link

coveralls commented Jul 7, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 72.504% when pulling 53d1fa2 on howieyuen:3-way-diff into 9ba14e2 on KusionStack:main.

@howieyuen howieyuen mentioned this pull request Jul 7, 2022
Closed
@howieyuen howieyuen force-pushed the 3-way-diff branch 4 times, most recently from 9ad29d4 to 044b13a Compare July 7, 2022 09:24
@SparkYuan SparkYuan added engine kind/feature Categorizes issue or PR as related to a new feature labels Jul 11, 2022
@SparkYuan SparkYuan added this to the v0.6.0 milestone Jul 11, 2022
adohe
adohe approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@adohe adohe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm.

@howieyuen howieyuen merged commit 88b28a7 into KusionStack:main Jul 12, 2022
@howieyuen howieyuen deleted the 3-way-diff branch July 12, 2022 02:37
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@adohe adohe adohe approved these changes

Assignees

@SparkYuan SparkYuan

@adohe adohe

Labels
kind/feature Categorizes issue or PR as related to a new feature
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@howieyuen @coveralls @SparkYuan @adohe