-
Notifications
You must be signed in to change notification settings - Fork 87
refactor Runtime interface #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
squash commits into one, try to keep PR mono |
This PR will be merged in suqash automatically by github |
I have to say, this is really not a good habit. |
please reorganize import statements by the way when squashing commits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm, will open other PR to fix import issue.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
pkg/engine/runtime
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
refactor engine/runtime and do not change any features
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.