Skip to content

State: add HTTPState as a new StateStorage #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2022

Conversation

SparkYuan
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/engine/states

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

Add the HttpState backend to provide a generic way to manipulate State in third-party services

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Test cases in pkg/engine/states/http_state_test.go

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Add HTTPState as a new StateStorage

@SparkYuan SparkYuan requested review from elliotxx, ldxdl, adohe and a team June 26, 2022 15:17
@coveralls
Copy link

coveralls commented Jun 26, 2022

Coverage Status

Coverage decreased (-0.05%) to 73.49% when pulling db2cb81 on SparkYuan:main into fd58099 on KusionStack:main.

@adohe
Copy link
Contributor

adohe commented Jun 27, 2022

Generally LGTM. But there still remains some aspect of optimization, for example: re-org the package, uniform the state_storage concept and backend.

@adohe adohe self-assigned this Jun 27, 2022
@adohe adohe added the engine label Jun 27, 2022
@adohe adohe added this to the v0.5.0 milestone Jun 27, 2022
Copy link
Contributor

@elliotxx elliotxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@SparkYuan SparkYuan merged commit afdf541 into KusionStack:main Jun 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants