Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: complete appconfiguartion model unit tests #484

Merged
merged 2 commits into from
Aug 22, 2023
Merged

test: complete appconfiguartion model unit tests #484

merged 2 commits into from
Aug 22, 2023

Conversation

elliotxx
Copy link
Contributor

What type of PR is this?

/kind test

What this PR does / why we need it:

  • Complete appconfiguartion model unit tests
  • Fix wrong acceptor type of MarshalJSON and MarshalYAML

@elliotxx elliotxx changed the title test: complete appconfiguartion model unit tests [WIP] test: complete appconfiguartion model unit tests Aug 22, 2023
@elliotxx elliotxx self-assigned this Aug 22, 2023
@elliotxx elliotxx added this to the 0.9.0 milestone Aug 22, 2023
@elliotxx elliotxx linked an issue Aug 22, 2023 that may be closed by this pull request
Test: Unit test for completing generator package #478
Closed
@elliotxx elliotxx changed the title [WIP] test: complete appconfiguartion model unit tests test: complete appconfiguartion model unit tests Aug 22, 2023
@elliotxx elliotxx added the area/test Categorizes an issue or PR as relevant to test label Aug 22, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5936100574

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.4%) to 73.81%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/watch.go 1 85.93%
Totals Coverage Status
Change from base Build 5933941859: 1.4%
Covered Lines: 5580
Relevant Lines: 7560
💛 - Coveralls

@elliotxx elliotxx enabled auto-merge (squash) August 22, 2023 08:22
SparkYuan
SparkYuan approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elliotxx elliotxx merged commit 0136769 into KusionStack:main Aug 22, 2023
9 of 10 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

@ffforest ffforest Awaiting requested review from ffforest

@panshuai111 panshuai111 Awaiting requested review from panshuai111

@healthjyk healthjyk Awaiting requested review from healthjyk

@adohe adohe Awaiting requested review from adohe

@liu-hm19 liu-hm19 Awaiting requested review from liu-hm19

Assignees

@elliotxx elliotxx

Labels
area/test Categorizes an issue or PR as relevant to test
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

Test: Unit test for completing generator package
3 participants
@elliotxx @coveralls @SparkYuan