Skip to content

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Feb 20, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

  • skip unsupported resources instead of returning error
  • wait for the first watched obj if has dependent
  • replace go module ref to ignore ASCII color codes

Which issue(s) this PR fixes:

Fixes #253

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., design docs, usage docs, etc.:

NONE

@howieyuen howieyuen enabled auto-merge (squash) February 20, 2023 12:09
@howieyuen howieyuen changed the title chore: optimize watch operation bugfix: kusion watch has no pod details Feb 20, 2023
@howieyuen howieyuen disabled auto-merge February 20, 2023 12:10
@howieyuen howieyuen enabled auto-merge (squash) February 20, 2023 12:10
- skip unsupported resources instead of returning error
- wait for the first watched obj if has dependent
- replace with github.com/howieyuen/uilive for ignoring ASCII color codes
@coveralls
Copy link

coveralls commented Feb 20, 2023

Pull Request Test Coverage Report for Build 4223261364

  • 12 of 17 (70.59%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.05%) to 72.131%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/engine/operation/watch.go 11 13 84.62%
pkg/cmd/apply/options.go 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/cmd/apply/options.go 1 74.0%
Totals Coverage Status
Change from base Build 4173273503: 0.05%
Covered Lines: 4677
Relevant Lines: 6484

💛 - Coveralls

@howieyuen howieyuen added kind/bug Something isn't working area/cli labels Feb 20, 2023
@SparkYuan SparkYuan requested a review from healthjyk February 21, 2023 06:12
@howieyuen howieyuen merged commit ca7a644 into KusionStack:main Feb 22, 2023
@howieyuen howieyuen deleted the watch branch February 22, 2023 12:31
@github-actions github-actions bot locked and limited conversation to collaborators Feb 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kusion watch cannot see pod details
3 participants