feat: watch support kubevela Application from core.oam.dev/v1beta1 #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both github.com/kubevela/kubevela or github.com/kubevela/kubevela-core-api has replace statement in go.mod, so copy them into third party
howieyuen
added
the
kind/feature
howieyuen
force-pushed
the
oam
branch
2 times, most recently
from
6ac4da8 to
6a33eba
Compare
Pull Request Test Coverage Report for Build 4121328575
💛 - Coveralls |
SparkYuan
reviewed
Feb 9, 2023
howieyuen
changed the title
SparkYuan
approved these changes
Feb 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Support kubevela integration, after custom health check extension is ready, we can revert this PR.
Note:
kubevela Application API cannot imported by go module directly, because the replace statement will break go install.
I also tried the kubevela-core-api, still get the same result.
Which issue(s) this PR fixes:
related #204
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., design docs, usage docs, etc.: