delete the replace domain in go.mod for go install
#189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SparkYuan
force-pushed
the
tidy-mod
branch
2 times, most recently
from
9f75be0 to
35249db
Compare
Pull Request Test Coverage Report for Build 3656276777
💛 - Coveralls |
SparkYuan
force-pushed
the
tidy-mod
branch
2 times, most recently
from
75b3db6 to
d9972ed
Compare
|
directly copy Terraform's source code??? |
Yes, because of the limitation of Terraform, currently, we have to reuse some code by copying source code instead of importing by go mod. We will upgrade our DAG structure and delete these TF related code in Jan 2023 |
howieyuen
reviewed
Dec 8, 2022
howieyuen
reviewed
Dec 8, 2022
|
please rebase main branch and re-arrange these commits as follows:
|
2. import tf related codes
|
delete this file: third_party/pulumi/doc.go |
howieyuen
approved these changes
Dec 12, 2022
markliby
approved these changes
Dec 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package terraform contains codes about "terraform/dag" and "terraform/tfdiags" copied from Terraform.
Terraform is an open-source project but makes almost all codes in an internal package. It's not a friendly way to benefit the open-source community.
The latest non-internal Terraform version is v0.15.3, but the k8s related modules in it are less than v1.15. That is too old for us
and is incompatible with our existing modules.
We import terraform/dag to reuse its DAG structure, and we will build our own DAG structure to support more complex Kusion workflow later.
We import terraform/tfdiags because terraform/dag imported this module, this module will be deleted together when we replace the DAG
structure with our own.
I update go version to 1.18 because of generics are used in TF's codes