Skip to content

Conversation

SparkYuan
Copy link
Member

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

pkg/kusionctl/cmd

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@SparkYuan SparkYuan force-pushed the fix-unsupport-resource-type branch from 9639169 to 217dcb3 Compare December 5, 2022 09:55
@coveralls
Copy link

coveralls commented Dec 5, 2022

Pull Request Test Coverage Report for Build 3618880848

  • 12 of 28 (42.86%) changed or added relevant lines in 4 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.3%) to 72.144%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/kusionctl/cmd/apply/options.go 4 6 66.67%
pkg/kusionctl/cmd/destroy/options.go 5 7 71.43%
pkg/kusionctl/cmd/preview/options.go 3 5 60.0%
pkg/kusionctl/cmd/util/helpers.go 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/engine/operation/parser/parser.go 3 75.0%
pkg/kusionctl/cmd/apply/options.go 7 70.16%
Totals Coverage Status
Change from base Build 3589366913: -0.3%
Covered Lines: 4566
Relevant Lines: 6329

💛 - Coveralls

@SparkYuan SparkYuan enabled auto-merge (squash) December 5, 2022 12:11
@SparkYuan SparkYuan disabled auto-merge December 5, 2022 12:12
@SparkYuan SparkYuan enabled auto-merge (squash) December 5, 2022 12:12
@SparkYuan SparkYuan requested a review from markliby December 5, 2022 12:37
@SparkYuan SparkYuan merged commit 16946d2 into KusionStack:main Dec 5, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
@SparkYuan SparkYuan deleted the fix-unsupport-resource-type branch June 26, 2023 07:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants