Skip to content

feat: kusion watch supports apps/v1 resources #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2022
Merged

feat: kusion watch supports apps/v1 resources #168

merged 1 commit into from
Nov 21, 2022

Conversation

howieyuen
Copy link
Collaborator

related: #23 (comment)

@howieyuen howieyuen enabled auto-merge (squash) November 18, 2022 08:10
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3495494022

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 14 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.08%) to 72.228%
Files with Coverage Reduction New Missed Lines %
pkg/kusionctl/cmd/destroy/options.go 7 83.25%
pkg/kusionctl/cmd/apply/options.go 7 73.77%
Totals Coverage Status
Change from base Build 3468723161: -0.08%
Covered Lines: 4559
Relevant Lines: 6312
💛 - Coveralls

markliby
markliby approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@markliby markliby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

SparkYuan
SparkYuan approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit a6e0e5a into KusionStack:main Nov 21, 2022
@howieyuen howieyuen deleted the watch-appsv1 branch November 21, 2022 03:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

+1 more reviewer

@markliby markliby markliby approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howieyuen @coveralls @SparkYuan @markliby