Skip to content

revert: no shorthand for applyOptions.Watch #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

revert: no shorthand for applyOptions.Watch #145

merged 1 commit into from
Oct 17, 2022

Conversation

howieyuen
Copy link
Collaborator

No description provided.

@howieyuen howieyuen enabled auto-merge (squash) October 17, 2022 02:51
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3262018831

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 73.779%
Totals Coverage Status
Change from base Build 3134219361: 0.007%
Covered Lines: 4516
Relevant Lines: 6121
💛 - Coveralls

SparkYuan
SparkYuan approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen merged commit 414a12b into KusionStack:main Oct 17, 2022
@howieyuen howieyuen deleted the compile-flag branch October 17, 2022 03:21
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

+1 more reviewer

@markliby markliby markliby approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howieyuen @coveralls @SparkYuan @markliby