Skip to content

feat: kusion watch supports resources of corev1 kinds #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

feat: kusion watch supports resources of corev1 kinds #144

merged 1 commit into from
Oct 21, 2022

Conversation

howieyuen
Copy link
Collaborator

@howieyuen howieyuen commented Oct 11, 2022 •
edited
Loading

related: #23 (comment)

@howieyuen howieyuen mentioned this pull request Oct 11, 2022
Closed
@coveralls
Copy link

coveralls commented Oct 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3248797615

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 73.739%
Files with Coverage Reduction New Missed Lines %
pkg/kusionctl/cmd/apply/options.go 7 73.77%
Totals Coverage Status
Change from base Build 3134219361: -0.03%
Covered Lines: 4518
Relevant Lines: 6127
💛 - Coveralls

SparkYuan
SparkYuan approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@SparkYuan SparkYuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@howieyuen howieyuen enabled auto-merge (squash) October 21, 2022 08:07
@howieyuen howieyuen merged commit 91c7249 into KusionStack:main Oct 21, 2022
@howieyuen howieyuen deleted the watch-v1 branch October 21, 2022 08:13
@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SparkYuan SparkYuan SparkYuan approved these changes

+1 more reviewer

@markliby markliby markliby approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@howieyuen @coveralls @SparkYuan @markliby